Re: [PATCH v2 0/8] MR704: mshtml: sessionStorage implementation.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/htmlstorage.c:
> HTMLStorage *This = impl_from_IHTMLStorage(iface);
> -    FIXME("(%p)->()\n", This);
> -    return E_NOTIMPL;
> +    HRESULT hres = S_OK;
> +    HANDLE file;
> +    DWORD count;
> +
> +    if(!This->filename) {
> +        clear_session_storage(This->session_storage);
> +        return S_OK;
> +    }
> +
> +    WaitForSingleObject(This->mutex, INFINITE);
> +
> +    /* Clear the file, if it exists */
> +    file = CreateFileW(This->filename, GENERIC_WRITE, 0, NULL, TRUNCATE_EXISTING, 0, NULL);

I think you could just delete the file in that case. We should do the right thing when the file is missing.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/704#note_6945