Re: [PATCH v7 0/6] MR8890: windows.devices.enumeration: Add support for parsing AQS filter strings.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/windows.devices.enumeration/aqs.c:
> +        for (i = 1; str[i]; i++)
> +        {
> +            if (str[i] == '\"')
> +            {
> +                if (str[i+1] && str[i+1] == '\"')
> +                {
> +                    i++;
> +                    continue;
> +                }
> +                break;
> +            }
> +        }
> +        if (str[i])
> +            i++;
> +        *token = TK_STRING;
> +        return i;
> What do you think of this instead?

```suggestion:-15+0
        /* lookup for end double quote, skipping any "" escaped double quotes */
        for (i = 1; str[i]; i++) if (str[i] == '\"' && str[++i] != '\"') break;
        if (i == 1 || str[i - 1] != '\"') break; /* illegal */
        *token = TK_STRING;
        return i;
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8890#note_115220