Re: [PATCH v2 0/3] MR6744: dlls/setupapi: Implement SetupDiGetDevicePropertyKeys

[Elizabeth Figura (＠zfigura)]

Elizabeth Figura (@zfigura) commented about dlls/setupapi/devinst.c:
> +        len = 39;
> +        ls = RegEnumKeyExW( hkey, i, guid_str, &len, NULL, NULL, NULL, NULL );
> +        if (ls)
> +        {
> +            if (ls == ERROR_NO_MORE_ITEMS)
> +                ls = ERROR_SUCCESS;
> +            else
> +                ERR( "Could not enumerate subkeys for device %s: %lu\n",
> +                     debugstr_w( device->instanceId ), ls );
> +            break;
> +        }
> +        swprintf( key_name, ARRAY_SIZE( key_name ), L"Properties\\%s", guid_str );
> +        ls = RegOpenKeyExW( device->key, key_name, 0, KEY_ENUMERATE_SUB_KEYS, &propkey );
> +        if (ls)
> +            break;
> +        if (FAILED( CLSIDFromString( guid_str, &prop_guid ) ))
> Should be UuidFromStringW() like the rest of the file. Using CLSIDFromString() will trigger ole32 delay import which I think we want to avoid.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6744#note_87520