30 Jan
2024
30 Jan
'24
7:05 p.m.
Francisco Casas (@fcasas) commented about programs/vkd3d-compiler/main.c:
int ret;
if (!parse_command_line(argc, argv, &options)) - return 1; + goto done;
if (options.print_help) { print_usage(argv[0]); - return 0; + fail = 0;
It may be just me, but I think that it is more intuitive to set `fail = 1` on errors rather than `fail = 0` on regular code paths. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/615#note_59518