Re: [PATCH v3 0/2] MR7169: ntdll: Fix the return value of NtDelayExecution.

[Paul Gofman (＠gofman)]

Paul Gofman (@gofman) commented about dlls/ntdll/tests/sync.c:
> + */
> +
> +static VOID CALLBACK apc_proc( ULONG_PTR param )
> +{
> +    InterlockedIncrement( (LONG *)param );
> +}
> +
> +struct delay_param
> +{
> +    BOOLEAN alertable;
> +    LONGLONG timeout;
> +    BOOLEAN queue_apc;
> +    const char *desc;
> +};
> +
> +static const struct delay_param tests[] =
> We usually define such static arrays and related structure definitions inside test itself unless that is shared with some other test functions. Also, we usually omit a separate test parameters declaration and declare just as:
> struct
> {
>     BOOLEAN alertable;
>     LONGLONG timeout;
>     BOOLEAN queue_apc;
>     const char *desc;
> }
> tests[] =
> {
>    { ... },
> };
You probably don't need ```const struct delay_param *test = &tests[j];``` below, tests[j] is almost same length.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7169#note_92810