14 Mar
2025
14 Mar
'25
5:38 p.m.
On Fri Mar 14 13:15:08 2025 +0000, Jinoh Kang wrote:
Sorry, I was mistaken, it wouldn't be a no-op. To be honest I'm not sure how frequent such scenario would be in practice. I also wonder what the semantics for bind mounts should be in practice--perhaps like directory junctions? In any case it is not immediately clear `if (!is_dir)` check is correct, or serves as a performance advantage. Making the directory comparison unconditional should simplify the logic too. Thanks for spotting it. You're right, I actually wanted to have less impact on directories but it's better this way for sure.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6855#note_97821