31 Jul
2025
31 Jul
'25
10:15 a.m.
On Thu Jul 31 09:04:42 2025 +0000, Huw Davies wrote:
At this point `audiobytes1` is guaranteed to be non-zero, so we don't need the test. Also, since we already have that earlier check on `audiobytes1`, I wonder if it's worth testing if `lplpaudioptr1` behaves in the same way (i.e. returns `DSERR_INVALIDPARAM`), if so that would mean the handling of the `*1` params could be the same. Good point. And good point; changing that makes the two crashes-on-wine tests succeed, with no regressions.
Clear improvements. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8632#note_111625