Re: [PATCH v22 0/3] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.

[Vibhav Pant (＠vibhavp)]

On Tue Aug 20 22:57:48 2024 +0000, Elizabeth Figura wrote:
> The logic surrounding "name_src" in this function seems awkwardly
> structured. The point is apparently to deep-copy the structure contents,
> but the two arms have different fields, and trying to unify one of the
> strings is unidiomatic and I don't think really saves you anything.
> Rather, I think this function should
> (1) convert to DEV_BROADCAST_DEVICEINTERFACE_W and broadcast
> (2) deep-copy the struct
> (3) queue the copied struct
> as three separate and subsequent operations. (2) should probably also be
> a helper function.
> I have separated (2) into its own function, `new_event`.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_79526