Re: [PATCH v3 0/6] MR846: uiautomationcore: Implement basic HWND based HUIANODE behavior. (v2)

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/uiautomationcore/uia_client.c:
> +        goto exit;
> +
> +    hr = IGlobalInterfaceTable_RegisterInterfaceInGlobal(git, (IUnknown *)&prov->IWineUiaProvider_iface,
> +            &IID_IWineUiaProvider, &node->git_cookie);
> +exit:
> +    if (FAILED(hr))
> +        IWineUiaProvider_Release(&prov->IWineUiaProvider_iface);
> +
> +    return hr;
> +}
> +
> +static HRESULT uia_get_provider_from_hwnd(struct uia_node *node)
> +{
> +    LRESULT lr;
> +
> +    SetLastError(NOERROR);
> It probably doesn't matter but it seems like NOERROR is an HRESULT and you probably want NO_ERROR or ERROR_SUCCESS.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/846#note_8881