Re: [PATCH 0/8] MR3423: Iphlpapi: Implement NotifyAddrChange.

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/nsi/nsi.c:
> break;
>      }
>      return TRUE;
>  }
>
> -static inline HANDLE get_nsi_device( void )
> +static inline HANDLE get_nsi_device( BOOL async )
>  {
> +    HANDLE *cached_device = async ? &nsi_device_async : &nsi_device;
>      HANDLE device;
>
> -    if (nsi_device == INVALID_HANDLE_VALUE)
> +    if (*cached_device == INVALID_HANDLE_VALUE)
>      {
> -        device = CreateFileW( L"\\\\.\\Nsi", 0, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, OPEN_EXISTING, 0, NULL );
> +        device = CreateFileW( L"\\\\.\\Nsi", 0, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, OPEN_EXISTING, FILE_FLAG_OVERLAPPED, NULL );

```suggestion:-0+0
        device = CreateFileW( L"\\\\.\\Nsi", 0, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, OPEN_EXISTING, async ? FILE_FLAG_OVERLAPPED : 0, NULL );
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3423#note_40427