[PATCH 0/1] MR1930: urlmon/tests: Don't cache data in the BindToStorage tests.

[Hans Leidekker (＠hans)]

This avoids wininet test failures when run after the urlmon tests.

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=51227

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1930

[PATCH 1/1] urlmon/tests: Don't cache data in the BindToStorage tests.

[Hans Leidekker]

From: Hans Leidekker <hans(a)codeweavers.com>

This avoids wininet test failures when run after the urlmon tests.

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=51227
---
 dlls/urlmon/tests/url.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/urlmon/tests/url.c b/dlls/urlmon/tests/url.c
index ef2a742b726..74dfaaf5449 100644
--- a/dlls/urlmon/tests/url.c
+++ b/dlls/urlmon/tests/url.c
@@ -4084,7 +4084,7 @@ START_TEST(url)
             http_is_first = TRUE;
             test_BindToStorage(HTTPS_TEST, BINDTEST_INVALID_CN, TYMED_ISTREAM);
 
-            bindf = BINDF_ASYNCHRONOUS | BINDF_ASYNCSTORAGE | BINDF_PULLDATA;
+            bindf = BINDF_ASYNCHRONOUS | BINDF_ASYNCSTORAGE | BINDF_PULLDATA | BINDF_NOWRITECACHE;
 
             trace("asynchronous https test (invalid CN, fail)\n");
             onsecurityproblem_hres = E_FAIL;
@@ -4100,7 +4100,7 @@ START_TEST(url)
             invalid_cn_accepted = FALSE;
 
             trace("asynchronous https test...\n");
-            test_BindToStorage(HTTPS_TEST, 0, TYMED_ISTREAM);
+            test_BindToStorage(HTTPS_TEST, BINDTEST_ALLOW_FINDINGRESOURCE, TYMED_ISTREAM);
         }else {
             win_skip("Skipping https tests\n");
         }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1930

[Jacek Caban (＠jacek)]

I think it would be interesting to make wininet tests more reliable and I'd expect that using INTERNET_FLAG_RELOAD in the problematic request should be enough.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1930#note_20624

[Hans Leidekker (＠hans)]

Yes, that works too. I have opened a new MR.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1930#note_20665

[PATCH 0/1] MR1930: urlmon/tests: Don't cache data in the BindToStorage tests. - closed

[Hans Leidekker (＠hans)]

This merge request was closed by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1930