[PATCH 0/2] MR981: dxgi/tests: Mark tests failing randomly on Windows as flaky.

[Francois Gouget (＠fgouget)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/981

[PATCH 1/2] dxgi/tests: Mark the test_swapchain_window_styles() tests failing randomly on Windows as flaky.

[Francois Gouget]

From: Francois Gouget <fgouget(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53228
---
 dlls/dxgi/tests/dxgi.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/dlls/dxgi/tests/dxgi.c b/dlls/dxgi/tests/dxgi.c
index 1874bcc0834..8c16cd37d45 100644
--- a/dlls/dxgi/tests/dxgi.c
+++ b/dlls/dxgi/tests/dxgi.c
@@ -6120,6 +6120,7 @@ static void test_swapchain_window_styles(void)
         exstyle = GetWindowLongA(swapchain_desc.OutputWindow, GWL_EXSTYLE);
         ok(style == tests[i].expected_style, "Got unexpected style %#lx, expected %#lx.\n",
                 style, tests[i].expected_style);
+        flaky_if(i == 4)
         ok(exstyle == tests[i].expected_exstyle, "Got unexpected exstyle %#lx, expected %#lx.\n",
                 exstyle, tests[i].expected_exstyle);
 
@@ -6136,6 +6137,7 @@ static void test_swapchain_window_styles(void)
         exstyle = GetWindowLongA(swapchain_desc.OutputWindow, GWL_EXSTYLE);
         ok(style == tests[i].expected_style, "Got unexpected style %#lx, expected %#lx.\n",
                 style, tests[i].expected_style);
+        flaky_if(i == 4)
         ok(exstyle == tests[i].expected_exstyle, "Got unexpected exstyle %#lx, expected %#lx.\n",
                 exstyle, tests[i].expected_exstyle);
 
@@ -6164,6 +6166,7 @@ static void test_swapchain_window_styles(void)
         exstyle = GetWindowLongA(swapchain_desc.OutputWindow, GWL_EXSTYLE);
         ok(style == tests[i].expected_style, "Got unexpected style %#lx, expected %#lx.\n",
                 style, tests[i].expected_style);
+        flaky_if(i == 4)
         ok(exstyle == tests[i].expected_exstyle, "Got unexpected exstyle %#lx, expected %#lx.\n",
                 exstyle, tests[i].expected_exstyle);
 
@@ -6190,7 +6193,7 @@ static void test_swapchain_window_styles(void)
             exstyle = GetWindowLongA(swapchain_desc.OutputWindow, GWL_EXSTYLE);
             todo_wine ok(style == tests[i].expected_style, "Got unexpected style %#lx, expected %#lx.\n",
                     style, tests[i].expected_style);
-            todo_wine
+            flaky_if(i == 4) todo_wine
             ok(exstyle == tests[i].expected_exstyle, "Got unexpected exstyle %#lx, expected %#lx.\n",
                     exstyle, tests[i].expected_exstyle);
         }
@@ -6206,7 +6209,7 @@ static void test_swapchain_window_styles(void)
         exstyle = GetWindowLongA(swapchain_desc.OutputWindow, GWL_EXSTYLE);
         todo_wine ok(style == tests[i].expected_style, "Got unexpected style %#lx, expected %#lx.\n",
                 style, tests[i].expected_style);
-        todo_wine
+        flaky_if(i == 4) todo_wine
         ok(exstyle == tests[i].expected_exstyle, "Got unexpected exstyle %#lx, expected %#lx.\n",
                 exstyle, tests[i].expected_exstyle);
 
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/981

[PATCH 2/2] dxgi/tests: Mark the test_swapchain_window_messages() tests failing randomly on Windows as flaky.

[Francois Gouget]

From: Francois Gouget <fgouget(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53229
---
 dlls/dxgi/tests/dxgi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/dxgi/tests/dxgi.c b/dlls/dxgi/tests/dxgi.c
index 8c16cd37d45..73ea891119f 100644
--- a/dlls/dxgi/tests/dxgi.c
+++ b/dlls/dxgi/tests/dxgi.c
@@ -5817,6 +5817,7 @@ static BOOL check_message(const struct message *expected,
 
 static LRESULT CALLBACK test_wndproc(HWND hwnd, unsigned int message, WPARAM wparam, LPARAM lparam)
 {
+    flaky
     ok(!expect_no_messages, "Got unexpected message %#x, hwnd %p, wparam %#Ix, lparam %#Ix.\n",
             message, hwnd, wparam, lparam);
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/981

[PATCH 0/2] MR981: dxgi/tests: Mark tests failing randomly on Windows as flaky. - approved

[Jan Sikorski (＠jsikorski)]

This merge request was approved by Jan Sikorski.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/981