[PATCH 0/1] MR6060: mmdevapi: Remove unused critical section from MMDevice.

[Brendan Shanks (＠bshanks)]

This was added in the [original MMDevice stub](9924b40eb99e13a653f9d2a32d26d97abc5de06c) in 2010, but was never used as far as I can tell.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6060

[PATCH 1/1] mmdevapi: Remove unused critical section from MMDevice.

[Brendan Shanks]

From: Brendan Shanks <bshanks(a)codeweavers.com>

---
 dlls/mmdevapi/devenum.c          | 5 -----
 dlls/mmdevapi/mmdevapi_private.h | 2 --
 2 files changed, 7 deletions(-)

diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c
index 52c88ad0a03..b1993573dd9 100644
--- a/dlls/mmdevapi/devenum.c
+++ b/dlls/mmdevapi/devenum.c
@@ -366,9 +366,6 @@ static MMDevice *MMDevice_Create(const WCHAR *name, GUID *id, EDataFlow flow, DW
         cur->IMMDevice_iface.lpVtbl = &MMDeviceVtbl;
         cur->IMMEndpoint_iface.lpVtbl = &MMEndpointVtbl;
 
-        InitializeCriticalSectionEx(&cur->crst, 0, RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO);
-        cur->crst.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": MMDevice.crst");
-
         list_add_tail(&device_list, &cur->entry);
     }else if(cur->ref > 0)
         WARN("Modifying an MMDevice with postitive reference count!\n");
@@ -584,8 +581,6 @@ static void MMDevice_Destroy(MMDevice *This)
 {
     TRACE("Freeing %s\n", debugstr_w(This->drv_id));
     list_remove(&This->entry);
-    This->crst.DebugInfo->Spare[0] = 0;
-    DeleteCriticalSection(&This->crst);
     free(This->drv_id);
     free(This);
 }
diff --git a/dlls/mmdevapi/mmdevapi_private.h b/dlls/mmdevapi/mmdevapi_private.h
index 5ef19ffc0d1..38ab7d8f4a0 100644
--- a/dlls/mmdevapi/mmdevapi_private.h
+++ b/dlls/mmdevapi/mmdevapi_private.h
@@ -53,8 +53,6 @@ typedef struct MMDevice {
     IMMEndpoint IMMEndpoint_iface;
     LONG ref;
 
-    CRITICAL_SECTION crst;
-
     EDataFlow flow;
     DWORD state;
     GUID devguid;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6060

[PATCH 1/1] mmdevapi: Remove unused critical section from MMDevice.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=147042

Your paranoid android.


=== debian11b (64 bit WoW report) ===

Report validation errors:
mshtml:script crashed (c0000005)

[PATCH 0/1] MR6060: mmdevapi: Remove unused critical section from MMDevice. - approved

[Huw Davies (＠huw)]

This merge request was approved by Huw Davies.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6060