[PATCH 0/1] MR4056: shell32: Fix parsing empty arguments in parse_dde_command().

[Zebediah Figura (＠zfigura)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4056

[PATCH 1/1] shell32: Fix parsing empty arguments in parse_dde_command().

[Zebediah Figura]

From: Zebediah Figura <zfigura(a)codeweavers.com>

This fixes a hang in Microsoft Visual C++ 1.52 installation.
---
 dlls/shell32/dde.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/shell32/dde.c b/dlls/shell32/dde.c
index dcaf641f8f4..976dc2e394a 100644
--- a/dlls/shell32/dde.c
+++ b/dlls/shell32/dde.c
@@ -391,7 +391,7 @@ static DWORD parse_dde_command(HSZ hszTopic, WCHAR *command)
                 else
                 {
                     if (!(p = wcspbrk(command, L",()[]"))) goto error;
-                    while (p[-1] == ' ') p--;
+                    while (p > command && p[-1] == ' ') p--;
                 }
 
                 new_argv = realloc(argv, (argc + 1) * sizeof(*argv));
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4056

[PATCH 1/1] shell32: Fix parsing empty arguments in parse_dde_command().

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=138548

Your paranoid android.


=== debian11b (64 bit WoW report) ===

winhttp:
notification.c:1174: Test failed: got 521
notification.c:118: Test failed: 1181: expected status 0x80000 got 0x200000