[PATCH 0/1] MR8040: windowscodecs/tiff: Zero-initialize decoder structure.

[Nikolay Sivov (＠nsivov)]

This is causing freeing garbage pointers on destruction.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8040

[PATCH 1/1] windowscodecs/tiff: Zero-initialize decoder structure.

[Nikolay Sivov]

From: Nikolay Sivov <nsivov(a)codeweavers.com>

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
---
 dlls/windowscodecs/libtiff.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/dlls/windowscodecs/libtiff.c b/dlls/windowscodecs/libtiff.c
index 2e62e42c7bf..cc66339a7e0 100644
--- a/dlls/windowscodecs/libtiff.c
+++ b/dlls/windowscodecs/libtiff.c
@@ -1214,12 +1214,10 @@ HRESULT CDECL tiff_decoder_create(struct decoder_info *info, struct decoder **re
 {
     struct tiff_decoder *This;
 
-    This = malloc(sizeof(*This));
+    This = calloc(1, sizeof(*This));
     if (!This) return E_OUTOFMEMORY;
 
     This->decoder.vtable = &tiff_decoder_vtable;
-    This->tiff = NULL;
-    This->cached_tile = NULL;
     This->cached_tile_x = -1;
     *result = &This->decoder;
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8040

[PATCH 0/1] MR8040: windowscodecs/tiff: Zero-initialize decoder structure. - approved

[Esme Povirk (＠madewokherd)]

This merge request was approved by Esme Povirk.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8040