[PATCH v2 0/1] MR1950: widl: Initialize __frame to a default value (Coverity)

[Alistair Leslie-Hughes (＠alesliehughes)]

In the generate code, Converity is reporting __frame->code unitilized in the failed case.
When we initialize the object, then __f will also point to a fully initizliaed structure.

--
  v2: widl: Suppress a coverity warning
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1950

[PATCH v2 1/1] widl: Suppress a coverity warning

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

Knowning that frame->code will be set when the exception handler
is called.  Suppress this coverity issue.
---
 tools/widl/proxy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/widl/proxy.c b/tools/widl/proxy.c
index a80aa5d77fe..3d55cd73ee7 100644
--- a/tools/widl/proxy.c
+++ b/tools/widl/proxy.c
@@ -298,6 +298,7 @@ static void gen_proxy(type_t *iface, const var_t *func, int idx,
   if (has_ret) {
     indent++;
     proxy_free_variables( type_function_get_args(func->declspec.type), "" );
+    print_proxy( "/* coverity[uninit_use_in_call:SUPPRESS] */\n" );
     print_proxy( "_RetVal = NdrProxyErrorHandler(RpcExceptionCode());\n" );
     indent--;
   }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1950

[Alistair Leslie-Hughes (＠alesliehughes)]

The generated code cause a huge number of False positives and marking them all as such will be time consuming.
This will allows them to be addressed in one foul swoop.

For some reason, coverity isn't dealing with the Exception handler that is in place. So the only options I see are
1. Initial the Frame->code to 0
or
2. Tell coverity that this is a false positive and suppress them from being reported.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1950#note_28635

[Zebediah Figura (＠zfigura)]

I have no opinions on whether this approach is appropriate for upstream Wine; removing myself as reviewer.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1950#note_30308

[PATCH v2 0/1] MR1950: widl: Initialize __frame to a default value (Coverity) - approved

[Huw Davies (＠huw)]

This merge request was approved by Huw Davies.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1950