[PATCH 0/1] MR6894: d3dx9: Remove superfluous null check (Coverity)

[Fabian Maurer (＠DarkShadow44)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6894

[PATCH 1/1] d3dx9: Remove superfluous null check (Coverity)

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

---
 dlls/d3dx9_36/surface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c
index 61b0283796d..984e068f805 100644
--- a/dlls/d3dx9_36/surface.c
+++ b/dlls/d3dx9_36/surface.c
@@ -554,7 +554,7 @@ static HRESULT d3dx_save_pixels_to_memory(struct d3dx_pixels *src_pixels, const
 
     *dst_buffer = buffer;
 exit:
-    if (buffer && *dst_buffer != buffer)
+    if (*dst_buffer != buffer)
         ID3DXBuffer_Release(buffer);
     return hr;
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6894

[PATCH 1/1] d3dx9: Remove superfluous null check (Coverity)

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=149922

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
win.c:4070: Test failed: Expected active window 00000000021E016E, got 0000000000000000.
win.c:4071: Test failed: Expected focus window 00000000021E016E, got 0000000000000000.

[Matteo Bruni (＠Mystral)]

The check is definitely unnecessary right now. I'd expect that to change when support for more file formats is introduced, but I guess there is an argument for getting rid of the Coverity warning in the meantime, especially considering that code freeze is coming soon.

Can you also get rid of the `buffer` initialization at the top of the function while at it? It should be unnecessary as well.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6894#note_89095