[PATCH v2 0/1] MR1736: taskschd/tests: Fix test failures on newer version of Windows 10.
I created some new test failures yesterday, sorry for that. -- v2: taskschd/tests: Fix test failures on newer version of Windows 10. https://gitlab.winehq.org/wine/wine/-/merge_requests/1736
From: Sven Baars <sbaars(a)codeweavers.com> --- dlls/taskschd/tests/scheduler.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/taskschd/tests/scheduler.c b/dlls/taskschd/tests/scheduler.c index 4e156e7ef33..07ba0f4bd95 100644 --- a/dlls/taskschd/tests/scheduler.c +++ b/dlls/taskschd/tests/scheduler.c @@ -783,7 +783,10 @@ static void test_GetTask(void) /* Delete the folder and recreate it to prevent a crash on w1064v1507 */ hr = ITaskFolder_DeleteFolder(root, Wine, 0); - ok(hr == S_OK, "DeleteTask error %#lx\n", hr); + todo_wine + ok(hr == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND) || broken(hr == S_OK) /* w1064v1507 */, + "expected ERROR_FILE_NOT_FOUND, got %#lx\n", hr); + ITaskFolder_Release(folder); hr = ITaskFolder_CreateFolder(root, Wine, v_null, &folder); ok(hr == S_OK, "CreateFolder error %#lx\n", hr); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/1736
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=127416 Your paranoid android. === w7u_adm (32 bit report) === taskschd: scheduler.c:805: Test failed: DeleteTask error 0x80070005 scheduler.c:801: Test failed: 1: expected 0, got 0x800700b7 scheduler.c:801: Test failed: 2: expected 0x80070002, got 0 scheduler.c:805: Test failed: DeleteTask error 0x80070005 scheduler.c:805: Test failed: DeleteTask error 0x80070005 scheduler.c:817: Test failed: RegisterTask error 0x800700b7 scheduler.c:963: Test failed: DeleteTask error 0x80070005 scheduler.c:965: Test failed: DeleteTask error 0x80070005 scheduler.c:968: Test failed: expected ERROR_FILE_NOT_FOUND, got 0x80070005
participants (3)
-
Marvin -
Sven Baars -
Sven Baars (@sbaars)