[PATCH 0/1] MR7030: kernelbase: Don't try to print the path in the FIXME in GetTempPath2.

[Louis Lenders (＠xe)]

Currently it gives weird output in the console logs like "GetTempPath2W (260, L"\2898\99f6\6fff") semi-stub",
because the buffer is not yet filled with the path.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7030

[PATCH 1/1] kernelbase: Don't try to print the path in the FIXME in GetTempPath2.

[Louis Lenders]

From: Louis Lenders <xerox.xerox2000x(a)gmail.com>

Currently it gives weird output in the console logs like "GetTempPath2W (260, L"\2898\99f6\6fff") semi-stub",
because the buffer is not yet filled with the path.
---
 dlls/kernelbase/file.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/kernelbase/file.c b/dlls/kernelbase/file.c
index 249f476eb7e..f0dedfe3b14 100644
--- a/dlls/kernelbase/file.c
+++ b/dlls/kernelbase/file.c
@@ -2491,7 +2491,7 @@ DWORD WINAPI DECLSPEC_HOTPATCH GetTempPathW( DWORD count, LPWSTR path )
 DWORD WINAPI DECLSPEC_HOTPATCH GetTempPath2A(DWORD count, LPSTR path)
 {
     /* TODO: Set temp path to C:\Windows\SystemTemp\ when a SYSTEM process calls this function */
-    FIXME("(%lu, %s) semi-stub\n", count, path);
+    FIXME("(%lu, %p) semi-stub\n", count, path);
     return GetTempPathA(count, path);
 }
 
@@ -2502,7 +2502,7 @@ DWORD WINAPI DECLSPEC_HOTPATCH GetTempPath2A(DWORD count, LPSTR path)
 DWORD WINAPI DECLSPEC_HOTPATCH GetTempPath2W(DWORD count, LPWSTR path)
 {
     /* TODO: Set temp path to C:\Windows\SystemTemp\ when a SYSTEM process calls this function */
-    FIXME("(%lu, %s) semi-stub\n", count, debugstr_w(path));
+    FIXME("(%lu, %p) semi-stub\n", count, path);
     return GetTempPathW(count, path);
 }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7030

[PATCH 1/1] kernelbase: Don't try to print the path in the FIXME in GetTempPath2.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=150405

Your paranoid android.


=== debian11b (64 bit WoW report) ===

kernel32:
comm.c:1586: Test failed: Unexpected time 1000, expected around 500