Re: [PATCH v2 0/1] MR8808: winealsa: Fixed MIDI reset Control Change
22 Aug
2025
22 Aug
'25
10:07 a.m.
Generally looks good, thanks! However, could you reword the commit message to be something like: `winealsa: Send All Notes Off and Reset Controllers.` ? Also, could you update the similar code in `winecoreaudio.drv/coremidi.c`? There, we already send 0x7b first, so it's just a question of replacing the 0x40 with a 0x79 and updating the comment. This change can go as a second commit in this same MR. I appreciate that you probably can't compile on macOS, but the CI will catch any errors in this trivial change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8808#note_113589
115
Age (days ago)
115
Last active (days ago)
0 comments
1 participants
participants (1)
-
Huw Davies (@huw)