Re: [PATCH v2 0/5] MR5879: winegstreamer: Implement stubs for h264 encoder.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_transform.c:
> -            {
> -                gst_caps_unref(parsed_caps);
> -                parsed_caps = gst_caps_ref(src_caps);
> -            }
> -
> -            if (!(element = find_element(GST_ELEMENT_FACTORY_TYPE_DECODER, parsed_caps, sink_caps))
> -                    || !append_element(transform->container, element, &first, &last))
> -                goto out;
> -            break;
> -
> -        case WG_MAJOR_TYPE_AUDIO:
> -        case WG_MAJOR_TYPE_VIDEO:
> -            break;
> -        case WG_MAJOR_TYPE_UNKNOWN:
> -            GST_FIXME("Format %u not implemented!", input_format.major_type);
> +    if (!transform_create_transcoder(transform, src_caps, &input_format, &first, &last))
> Can we add an encoder element without changing all this code? It doesn't look like you need all the complicated converter sequence, maybe only a videoconvert (do you even need one?).

I don't want to be a blocker but to be honest I'm a bit annoyed with the idea of having to rewrite the patches I am trying to upstream with transform media types.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5879#note_73696