[PATCH 0/1] MR116: vkd3d-shader/hlsl: Fix some memory leaks in the function call rule.

[Zebediah Figura (＠zfigura)]

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/116

[PATCH 1/1] vkd3d-shader/hlsl: Fix some memory leaks in the function call rule.

[Zebediah Figura]

From: Zebediah Figura <zfigura(a)codeweavers.com>

---
 libs/vkd3d-shader/hlsl.y | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libs/vkd3d-shader/hlsl.y b/libs/vkd3d-shader/hlsl.y
index e011ea24..612432f0 100644
--- a/libs/vkd3d-shader/hlsl.y
+++ b/libs/vkd3d-shader/hlsl.y
@@ -5234,7 +5234,11 @@ primary_expr:
     | var_identifier '(' func_arguments ')'
         {
             if (!($$ = add_call(ctx, $1, &$3, &@1)))
+            {
+                vkd3d_free($1);
                 YYABORT;
+            }
+            vkd3d_free($1);
         }
     | NEW_IDENTIFIER
         {
-- 
GitLab

https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/116

[Henri Verbeet (＠hverbeet)]

I'm not terribly familiar with the HLSL parser, but it looks like there may be a couple of instances of similar issues as well.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/116#note_26535

[PATCH 0/1] MR116: vkd3d-shader/hlsl: Fix some memory leaks in the function call rule. - approved

[Henri Verbeet (＠hverbeet)]

This merge request was approved by Henri Verbeet.
-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/116

[Zebediah Figura (＠zfigura)]

> I'm not terribly familiar with the HLSL parser, but it looks like there may be a couple of instances of similar issues as well.

There are quite a lot of leaks, yeah; I'm just trying to fix them as I notice them...

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/116#note_26552