[PATCH 0/1] MR3801: user32/tests: Detect win7's broken GetQueueStatus behavior.

[Esme Povirk (＠madewokherd)]

Unlike most of these user32:msg failures, this one is consistent.

No bug report for this specifically but https://bugs.winehq.org/show_bug.cgi?id=53434 comments 3 and 4 has related info.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3801

[PATCH 1/1] user32/tests: Detect win7's broken GetQueueStatus behavior.

[Esme Povirk]

From: Esme Povirk <esme(a)codeweavers.com>

---
 dlls/user32/tests/msg.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index 6df3ebe284f..c05982a9939 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -13380,7 +13380,7 @@ static void test_PeekMessage(void)
     DWORD tid, qstatus;
     UINT qs_all_input = QS_ALLINPUT;
     UINT qs_input = QS_INPUT;
-    BOOL ret;
+    BOOL ret, broken_flags = FALSE;
     struct peekmsg_info info;
 
     info.hwnd = CreateWindowA("TestWindowClass", NULL, WS_OVERLAPPEDWINDOW,
@@ -13407,6 +13407,13 @@ static void test_PeekMessage(void)
         trace("QS_RAWINPUT not supported on this platform\n");
         qs_all_input &= ~QS_RAWINPUT;
         qs_input &= ~QS_RAWINPUT;
+
+        SetLastError(0xdeadbeef);
+        qstatus = GetQueueStatus(qs_all_input);
+        if (GetLastError() == ERROR_INVALID_FLAGS)
+            broken_flags = TRUE;
+        ok(GetLastError() == 0xdeadbeef || broken(GetLastError() == ERROR_INVALID_FLAGS) /* win7 */,
+            "wrong error %ld\n", GetLastError());
     }
     if (qstatus & QS_POSTMESSAGE)
     {
@@ -13426,10 +13433,14 @@ static void test_PeekMessage(void)
     if (!qstatus)
     {
         ok(GetLastError() == ERROR_INVALID_FLAGS, "wrong error %ld\n", GetLastError());
+        SetLastError(0xdeadbeef);
         qstatus = GetQueueStatus(qs_all_input);
+        ok(GetLastError() == 0xdeadbeef || broken(broken_flags && GetLastError() == ERROR_INVALID_FLAGS),
+            "wrong error %ld\n", GetLastError());
     }
     qstatus &= ~MAKELONG( 0x4000, 0x4000 );  /* sometimes set on Win95 */
-    ok(qstatus == MAKELONG(QS_SENDMESSAGE, QS_SENDMESSAGE),
+    ok(qstatus == MAKELONG(QS_SENDMESSAGE, QS_SENDMESSAGE) ||
+        broken(broken_flags && qstatus == 0),
        "wrong qstatus %08lx\n", qstatus);
 
     msg.message = 0;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3801

[PATCH 1/1] user32/tests: Detect win7's broken GetQueueStatus behavior.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

3 TestBot errors prevented a full analysis of your patch.
If the test caused the operating system (e.g. Windows) to crash or
reboot you will probably have to modify it to avoid that.
Other issues should be reported to the TestBot administrators.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=151898

Your paranoid android.


=== build (build log) ===

WineRunBuild.pl:error: Could not copy the patch to the VM: network read timed out (sendfile/connect:AgentVersion.h:0/9)
WineRunBuild.pl:error: BotError: The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

=== debian11 (build log) ===

WineRunWineTest.pl:error: Could not send 'patch.diff' to the VM: network read timed out (sendfile/connect:AgentVersion.h:0/9)
WineRunWineTest.pl:error: BotError: The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)
WineRunWineTest.pl:error: Giving up after 3 run(s)

=== debian11b (build log) ===

WineRunWineTest.pl:error: Could not send 'patch.diff' to the VM: network read timed out (sendfile/connect:AgentVersion.h:0/9)
WineRunWineTest.pl:error: BotError: The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)
WineRunWineTest.pl:error: Giving up after 3 run(s)