Re: [PATCH v6 0/4] MR8210: win32u: Use a pbuffer instead of OSmesa for memory DCs GL.
Fabian Maurer (@DarkShadow44) commented about dlls/win32u/opengl.c:
+ const struct opengl_funcs *funcs = &display_funcs; int interval; HWND hwnd;
- if (!(funcs = get_dc_funcs( hdc, NULL ))) - { - RtlSetLastWin32Error( ERROR_DC_NOT_FOUND ); - return FALSE; - } - driver_funcs = funcs == &display_funcs ? display_driver_funcs : memory_driver_funcs; - if (!(hwnd = NtUserWindowFromDC( hdc ))) interval = 0; else interval = get_window_swap_interval( hwnd );
+ if (context->memory_pbuffer) return flush_memory_pbuffer( context, hdc, FALSE, funcs->p_glFlush ); return driver_funcs->p_swap_buffers( context ? context->driver_private : NULL, hwnd, hdc, interval ); The `context` nullcheck is now pointless, since it's dereferenced anyways. Is that nullcheck superflous now, or should another nullcheck be added?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8210#note_106842
participants (1)
-
Fabian Maurer (@DarkShadow44)