Re: [PATCH v5 0/5] MR519: vkd3d-shader/dxil: Support minimum precision.

13 Dec 2023


      ...
```diff
-#if defined(SONAME_LIBDXCOMPILER) && !defined(VKD3D_CROSSTEST)
+#if defined(SONAME_LIBDXCOMPILER) || defined(VKD3D_CROSSTEST)
```
Should that just be "#if defined(SONAME_LIBDXCOMPILER)"? We could perhaps consider defining SONAME_LIBDXCOMPILER to "dxcompiler.dll" if it isn't already defined and we have VKD3D_CROSSTEST, but in principle I don't think VKD3D_CROSSTEST needs special handling here.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519#note_55909

Henri Verbeet (＠hverbeet)

tags

participants (1)