[PATCH 0/3] MR5773: mmdevapi: Fake success in a few IAudioSessionControl2 methods

[Fabian Maurer (＠DarkShadow44)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56763

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5773

[PATCH 1/3] mmdevapi: Fake success for control_SetGroupingParam

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56763
---
 dlls/mmdevapi/session.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mmdevapi/session.c b/dlls/mmdevapi/session.c
index 9a36adb5bf2..1f1e4c9458f 100644
--- a/dlls/mmdevapi/session.c
+++ b/dlls/mmdevapi/session.c
@@ -183,7 +183,7 @@ static HRESULT WINAPI control_SetGroupingParam(IAudioSessionControl2 *iface, con
 {
     struct audio_session_wrapper *This = impl_from_IAudioSessionControl2(iface);
     FIXME("(%p)->(%s, %s) - stub\n", This, debugstr_guid(group), debugstr_guid(session));
-    return E_NOTIMPL;
+    return S_OK;
 }
 
 static HRESULT WINAPI control_RegisterAudioSessionNotification(IAudioSessionControl2 *iface,
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/5773

[PATCH 2/3] mmdevapi: Fake success for control_SetIconPath

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56763
---
 dlls/mmdevapi/session.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mmdevapi/session.c b/dlls/mmdevapi/session.c
index 1f1e4c9458f..8e8a62df792 100644
--- a/dlls/mmdevapi/session.c
+++ b/dlls/mmdevapi/session.c
@@ -168,7 +168,7 @@ static HRESULT WINAPI control_SetIconPath(IAudioSessionControl2 *iface, const WC
 {
     struct audio_session_wrapper *This = impl_from_IAudioSessionControl2(iface);
     FIXME("(%p)->(%s, %s) - stub\n", This, debugstr_w(path), debugstr_guid(session));
-    return E_NOTIMPL;
+    return S_OK;
 }
 
 static HRESULT WINAPI control_GetGroupingParam(IAudioSessionControl2 *iface, GUID *group)
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/5773

[PATCH 3/3] mmdevapi: Fake success for control_SetDisplayName

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56763
---
 dlls/mmdevapi/session.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mmdevapi/session.c b/dlls/mmdevapi/session.c
index 8e8a62df792..6b11562520f 100644
--- a/dlls/mmdevapi/session.c
+++ b/dlls/mmdevapi/session.c
@@ -153,7 +153,7 @@ static HRESULT WINAPI control_SetDisplayName(IAudioSessionControl2 *iface, const
 {
     struct audio_session_wrapper *This = impl_from_IAudioSessionControl2(iface);
     FIXME("(%p)->(%p, %s) - stub\n", This, name, debugstr_guid(session));
-    return E_NOTIMPL;
+    return S_OK;
 }
 
 static HRESULT WINAPI control_GetIconPath(IAudioSessionControl2 *iface, WCHAR **path)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5773

[Huw Davies (＠huw)]

It doesn't seem like it would be too difficult to implement the setters and getters here (ignoring the event context params).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5773#note_72219