[PATCH 0/1] MR1849: winebus.sys: Declare a variable only when used

[Gerald Pfeifer (＠gerald)]

udev_add_device declares a variable (product) even when it is not
used on all platforms. Use the same condition for the declaration
that already guards the code.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

[PATCH 1/1] winebus.sys: Declare a variable only when used

[Gerald Pfeifer]

From: Gerald Pfeifer <gerald(a)pfeifer.com>

udev_add_device declares a variable (product) even when it is not
used on all platforms. Use the same condition for the declaration
that already guards the code.
---
 dlls/winebus.sys/bus_udev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/winebus.sys/bus_udev.c b/dlls/winebus.sys/bus_udev.c
index 3cd8bfd1ceb..34b3305ed88 100644
--- a/dlls/winebus.sys/bus_udev.c
+++ b/dlls/winebus.sys/bus_udev.c
@@ -1329,7 +1329,9 @@ static void udev_add_device(struct udev_device *dev, int fd)
     if (!strcmp(subsystem, "hidraw"))
     {
         static const WCHAR hidraw[] = {'h','i','d','r','a','w',0};
+#ifdef HAVE_LINUX_HIDRAW_H
         char product[MAX_PATH];
+#endif
 
         if (!desc.manufacturer[0]) memcpy(desc.manufacturer, hidraw, sizeof(hidraw));
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

[Gerald Pfeifer (＠gerald)]

I initially submitted this last December, with no reaction:
https://www.winehq.org/pipermail/wine-devel/2021-December/203565.html

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1849#note_19892

[PATCH 0/0] MR1849: winebus.sys: Declare a variable only when used - closed

[Gerald Pfeifer (＠gerald)]

This merge request was closed by Gerald Pfeifer.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1849

[PATCH 0/0] MR1849: winebus.sys: Declare a variable only when used

[Gerald Pfeifer (＠gerald)]

Apologies - I mis-operated git.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1849#note_19898