[PATCH 0/1] MR8838: iphlpapi: Add stub for SetPerTcp6ConnectionEStats.

[Louis Lenders (＠xe)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58635

(Note: in Windows SDK this is defined as ULONG WINAPI SetPerTcp6ConnectionEStats(.,.,., PUCHAR Rw .,.,.) so ULONG instead of DWORD, and PUCHAR instead of BYTE, but I conformed to the notation as currently in wine's iphlpapi.h)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8838

[PATCH 1/1] iphlpapi: Add stub for SetPerTcp6ConnectionEStats.

[Louis Lenders]

From: Louis Lenders <xerox.xerox2000x(a)gmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58635
---
 dlls/iphlpapi/iphlpapi.spec   |  2 +-
 dlls/iphlpapi/iphlpapi_main.c | 10 ++++++++++
 include/iphlpapi.h            |  1 +
 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec
index ed2214c99ce..f936d7d679d 100644
--- a/dlls/iphlpapi/iphlpapi.spec
+++ b/dlls/iphlpapi/iphlpapi.spec
@@ -285,7 +285,7 @@
 @ stub SetIpStatsToStack
 @ stdcall SetIpTTL( long )
 #@ stub SetNetworkInformation
-#@ stub SetPerTcp6ConnectionEStats
+@ stdcall SetPerTcp6ConnectionEStats( ptr long ptr long long long )
 #@ stub SetPerTcp6ConnectionStats
 @ stdcall SetPerTcpConnectionEStats( ptr long ptr long long long )
 #@ stub SetPerTcpConnectionStats
diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c
index 595f499c36e..bd2f5da7fe6 100644
--- a/dlls/iphlpapi/iphlpapi_main.c
+++ b/dlls/iphlpapi/iphlpapi_main.c
@@ -4143,6 +4143,16 @@ DWORD WINAPI SetPerTcpConnectionEStats(PMIB_TCPROW row, TCP_ESTATS_TYPE state, P
   return ERROR_NOT_SUPPORTED;
 }
 
+/******************************************************************
+ *    SetPerTcp6ConnectionEStats (IPHLPAPI.@)
+ */
+DWORD WINAPI SetPerTcp6ConnectionEStats(MIB_TCP6ROW *row, TCP_ESTATS_TYPE state, BYTE *rw,
+                                       ULONG version, ULONG size, ULONG offset)
+{
+  FIXME("(row %p, state %d, rw %p, version %lu, size %lu, offset %lu): stub\n",
+        row, state, rw, version, size, offset);
+  return ERROR_NOT_SUPPORTED;
+}
 
 /******************************************************************
  *    UnenableRouter (IPHLPAPI.@)
diff --git a/include/iphlpapi.h b/include/iphlpapi.h
index 84b9b7db34c..c93542c6be5 100644
--- a/include/iphlpapi.h
+++ b/include/iphlpapi.h
@@ -79,6 +79,7 @@ IPHLPAPI_DLL_LINKAGE DWORD WINAPI CreateIpForwardEntry(PMIB_IPFORWARDROW pRoute)
 IPHLPAPI_DLL_LINKAGE DWORD WINAPI SetIpForwardEntry(PMIB_IPFORWARDROW pRoute);
 IPHLPAPI_DLL_LINKAGE DWORD WINAPI DeleteIpForwardEntry(PMIB_IPFORWARDROW pRoute);
 IPHLPAPI_DLL_LINKAGE DWORD WINAPI SetIpStatistics(PMIB_IPSTATS pIpStats);
+IPHLPAPI_DLL_LINKAGE DWORD WINAPI SetPerTcp6ConnectionEStats(MIB_TCP6ROW *row, TCP_ESTATS_TYPE state, BYTE *rw, ULONG version, ULONG size, ULONG offset);
 IPHLPAPI_DLL_LINKAGE DWORD WINAPI SetPerTcpConnectionEStats(MIB_TCPROW *row, TCP_ESTATS_TYPE state, BYTE *rw, ULONG version, ULONG size, ULONG offset);
 IPHLPAPI_DLL_LINKAGE DWORD WINAPI SetIpTTL(UINT nTTL);
 IPHLPAPI_DLL_LINKAGE DWORD WINAPI CreateIpNetEntry(PMIB_IPNETROW pArpEntry);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8838

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/iphlpapi/iphlpapi_main.c:
> return ERROR_NOT_SUPPORTED;
>  }
>
> +/******************************************************************
> + *    SetPerTcp6ConnectionEStats (IPHLPAPI.@)
> + */
> +DWORD WINAPI SetPerTcp6ConnectionEStats(MIB_TCP6ROW *row, TCP_ESTATS_TYPE state, BYTE *rw,
> +                                       ULONG version, ULONG size, ULONG offset)
> Could you indent this line one more space?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8838#note_114065

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/iphlpapi/iphlpapi_main.c:
> return ERROR_NOT_SUPPORTED;
>  }
>
> +/******************************************************************
> + *    SetPerTcp6ConnectionEStats (IPHLPAPI.@)
> + */
> +DWORD WINAPI SetPerTcp6ConnectionEStats(MIB_TCP6ROW *row, TCP_ESTATS_TYPE state, BYTE *rw,
> +                                       ULONG version, ULONG size, ULONG offset)
> +{
> +  FIXME("(row %p, state %d, rw %p, version %lu, size %lu, offset %lu): stub\n",
> +        row, state, rw, version, size, offset);
> +  return ERROR_NOT_SUPPORTED;
> ...and let's use 4-space indents for the function body.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8838#note_114066