[PATCH 0/1] MR5295: mf/session: Avoid leaking samples in transform_node_deliver_samples.

[Rémi Bernon]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5295

[PATCH 1/1] mf/session: Avoid leaking samples in transform_node_deliver_samples.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

---
 dlls/mf/session.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/mf/session.c b/dlls/mf/session.c
index 9074ad2de25..ba18261674d 100644
--- a/dlls/mf/session.c
+++ b/dlls/mf/session.c
@@ -3334,7 +3334,10 @@ static void transform_node_deliver_samples(struct media_session *session, struct
         stream = &topo_node->u.transform.inputs[input];
 
         if (SUCCEEDED(transform_stream_pop_sample(stream, &sample)))
+        {
             session_deliver_sample_to_node(session, topo_node->node, input, sample);
+            IMFSample_Release(sample);
+        }
         else if (FAILED(hr = IMFTopologyNode_GetInput(topo_node->node, input, &up_node, &output)))
             WARN("Failed to get node %p/%lu input, hr %#lx\n", topo_node->node, input, hr);
         else
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5295

[PATCH 1/1] mf/session: Avoid leaking samples in transform_node_deliver_samples.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=144023

Your paranoid android.


=== debian11b (64 bit WoW report) ===

d3dx10_34:
d3dx10.c:4380: Test succeeded inside todo block: Got unexpected effect 00000000011C3A60.
d3dx10.c:4470: Test succeeded inside todo block: Got unexpected effect 00000000011D5770.
d3dx10.c:4480: Test succeeded inside todo block: Got unexpected effect 00000000011D5770.
d3dx10.c:4589: Test succeeded inside todo block: Got unexpected effect 00000000011A4A80.
d3dx10.c:4599: Test succeeded inside todo block: Got unexpected effect 00000000011D5770.

d3dx10_35:
d3dx10.c:4380: Test succeeded inside todo block: Got unexpected effect 00000000011BBB50.
d3dx10.c:4470: Test succeeded inside todo block: Got unexpected effect 00000000011E3BD0.
d3dx10.c:4480: Test succeeded inside todo block: Got unexpected effect 00000000011E3C90.
d3dx10.c:4589: Test succeeded inside todo block: Got unexpected effect 0000000001195C60.
d3dx10.c:4599: Test succeeded inside todo block: Got unexpected effect 00000000011D4950.

d3dx10_37:
d3dx10.c:4380: Test succeeded inside todo block: Got unexpected effect 00000000011E3990.
d3dx10.c:4470: Test succeeded inside todo block: Got unexpected effect 00000000011946B0.
d3dx10.c:4480: Test succeeded inside todo block: Got unexpected effect 0000000001194880.
d3dx10.c:4589: Test succeeded inside todo block: Got unexpected effect 00000000011946B0.
d3dx10.c:4599: Test succeeded inside todo block: Got unexpected effect 00000000011B6010.

d3dx10_38:
d3dx10.c:4380: Test succeeded inside todo block: Got unexpected effect 00000000011E37E0.
d3dx10.c:4470: Test succeeded inside todo block: Got unexpected effect 00000000011B7330.
d3dx10.c:4480: Test succeeded inside todo block: Got unexpected effect 00000000011E36E0.
d3dx10.c:4589: Test succeeded inside todo block: Got unexpected effect 00000000011B7330.
d3dx10.c:4599: Test succeeded inside todo block: Got unexpected effect 00000000011B5E80.

d3dx10_39:
d3dx10.c:4380: Test succeeded inside todo block: Got unexpected effect 00000000011D1B30.
d3dx10.c:4470: Test succeeded inside todo block: Got unexpected effect 00000000011D5C60.
d3dx10.c:4480: Test succeeded inside todo block: Got unexpected effect 00000000011D18E0.
d3dx10.c:4589: Test succeeded inside todo block: Got unexpected effect 00000000011D1AB0.
d3dx10.c:4599: Test succeeded inside todo block: Got unexpected effect 00000000011C3380.

d3dx10_40:
d3dx10.c:4380: Test succeeded inside todo block: Got unexpected effect 00000000011D6900.
d3dx10.c:4470: Test succeeded inside todo block: Got unexpected effect 00000000011D6830.
d3dx10.c:4480: Test succeeded inside todo block: Got unexpected effect 0000000001195B70.
d3dx10.c:4589: Test succeeded inside todo block: Got unexpected effect 00000000011929A0.
d3dx10.c:4599: Test succeeded inside todo block: Got unexpected effect 00000000011D6830.

d3dx10_41:
d3dx10.c:4380: Test succeeded inside todo block: Got unexpected effect 0000000001239E90.
d3dx10.c:4470: Test succeeded inside todo block: Got unexpected effect 00000000011A4A10.
d3dx10.c:4480: Test succeeded inside todo block: Got unexpected effect 00000000011A4A10.
d3dx10.c:4589: Test succeeded inside todo block: Got unexpected effect 00000000011A4A10.
d3dx10.c:4599: Test succeeded inside todo block: Got unexpected effect 00000000011D1BC0.

d3dx10_42:
d3dx10.c:4380: Test succeeded inside todo block: Got unexpected effect 00000000011E3990.
d3dx10.c:4470: Test succeeded inside todo block: Got unexpected effect 00000000011E3B60.
d3dx10.c:4480: Test succeeded inside todo block: Got unexpected effect 00000000011E3990.
d3dx10.c:4589: Test succeeded inside todo block: Got unexpected effect 00000000011E3B60.
d3dx10.c:4599: Test succeeded inside todo block: Got unexpected effect 0000000001193D50.

d3dx10_43:
d3dx10.c:4380: Test succeeded inside todo block: Got unexpected effect 0000000001239BC0.
d3dx10.c:4470: Test succeeded inside todo block: Got unexpected effect 00000000011E3650.
d3dx10.c:4480: Test succeeded inside todo block: Got unexpected effect 00000000011B6010.
d3dx10.c:4589: Test succeeded inside todo block: Got unexpected effect 0000000001195B90.
d3dx10.c:4599: Test succeeded inside todo block: Got unexpected effect 00000000011C3370.

[Rémi Bernon]

Anything wrong with this?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5295#note_66352

[PATCH 0/1] MR5295: mf/session: Avoid leaking samples in transform_node_deliver_samples. - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5295