Re: [PATCH v2 0/7] MR9979: mf/tests: Test SAR's IMFPresentationTimeSource interface.
Nikolay Sivov (@nsivov) commented about dlls/mf/tests/mf.c:
+ PropVariantClear(&propvar); + + /* Place an ENDOFSEGMENT marker after the third sample */ + hr = IMFStreamSink_PlaceMarker(stream, MFSTREAMSINK_MARKER_ENDOFSEGMENT, NULL, NULL); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + hr = gen_wait_media_event_until_blocking((IMFMediaEventGenerator*)stream, callback, MEStreamSinkMarker, 1000, &propvar); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + PropVariantClear(&propvar); + + /* Check clock time */ + while (time <= 300000) + { + IMFPresentationClock_GetTime(clock, &time); + Sleep(50); + } This does not look very safe to me. If we must to do GetTime(), maybe do it in a separate thread, and have a timeout?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9979#note_128139
participants (1)
-
Nikolay Sivov (@nsivov)