[PATCH 0/1] MR5275: configure: Don't explicitly enable -Wenum-conversion on Clang.

[Jacek Caban (＠jacek)]

Clang enables -Wenum-conversion by default anyway, we add it to CFLAGS to enable them on GCC.
When explicitly enabled, Clang also enables additional warnings. Some of those warnings, like
-Wenum-enum-conversion, are too strict to be practical with win32, so avoid enabling them.

Fixes warnings with LLVM git.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5275

[PATCH 1/1] configure: Don't explicitly enable -Wenum-conversion on Clang.

[Jacek Caban]

From: Jacek Caban <jacek(a)codeweavers.com>

Clang enables -Wenum-conversion by default anyway, we add it to CFLAGS to enable them on GCC.
When explicitly enabled, Clang also enables additional warnings. Some of those warnings, like
-Wenum-enum-conversion, are too strict to be practical with win32, so avoid enabling them.
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 417b1a63a13..67f823a68e8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -966,7 +966,7 @@ This is an error since --enable-archs=$wine_arch was requested.])])
     WINE_TRY_PE_CFLAGS([-Wpointer-arith])
     WINE_TRY_PE_CFLAGS([-Wlogical-op])
     WINE_TRY_PE_CFLAGS([-Wabsolute-value])
-    WINE_TRY_PE_CFLAGS([-Wenum-conversion])
+    WINE_TRY_PE_CFLAGS([-Wenum-enum-conversion],[:],WINE_TRY_PE_CFLAGS([-Wenum-conversion]))
 
     dnl GCC can't handle large files when -Wmisleading-indentation is enabled (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89549)
     WINE_TRY_PE_CFLAGS([-flarge-source-files -Wmisleading-indentation],[AS_VAR_APPEND(${wine_arch}_EXTRACFLAGS,[" -Wno-misleading-indentation"])])
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5275

[PATCH 1/1] configure: Don't explicitly enable -Wenum-conversion on Clang.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=143941

Your paranoid android.


=== debian11b (64 bit WoW report) ===

secur32:
schannel.c:538: Test failed: cert_cnt = 2