[PATCH 0/1] MR993: ieframe/tests: Mark tests failing randomly on Windows as flaky.
From: Francois Gouget <fgouget(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53142 --- dlls/ieframe/tests/webbrowser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/ieframe/tests/webbrowser.c b/dlls/ieframe/tests/webbrowser.c index 584da6e9022..544f4b4ae77 100644 --- a/dlls/ieframe/tests/webbrowser.c +++ b/dlls/ieframe/tests/webbrowser.c @@ -2021,6 +2021,7 @@ static void test_ClientSite(IWebBrowser2 *unk, IOleClientSite *client, BOOL stop if(client) { DWORD count = pSetQueryNetSessionCount(SESSION_QUERY); + flaky ok(count == session_count + 1, "count = %lu expected %lu\n", count, session_count + 1); CHECK_CALLED(GetContainer); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/993
Jacek Caban (@jacek) commented about dlls/ieframe/tests/webbrowser.c:
if(client) { DWORD count = pSetQueryNetSessionCount(SESSION_QUERY); + flaky ok(count == session_count + 1, "count = %lu expected %lu\n", count, session_count + 1);
You could probably use ">=" instead of exact comparison to make the test more reliable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/993#note_10105
On Mon Oct 10 07:12:36 2022 +0000, Jacek Caban wrote:
You could probably use ">=" instead of exact comparison to make the test more reliable. I created !2040 for that.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/993#note_21997
This merge request was closed by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/993
participants (3)
-
Francois Gouget -
Francois Gouget (＠fgouget)
-
Jacek Caban (＠jacek)