[PATCH 0/1] MR6181: atl: Only warn in AtlModuleGetClassObject if the class was not found.

[Alex Henrie (＠alexhenrie)]

A warning should only be printed if something went wrong, not every time
the function is run.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6181

[PATCH 1/1] atl: Only warn in AtlModuleGetClassObject if the class was not found.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

A warning should only be printed if something went wrong, not every time
the function is run.
---
 dlls/atl/atl30.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/atl/atl30.c b/dlls/atl/atl30.c
index d7d130c2a03..62a74953190 100644
--- a/dlls/atl/atl30.c
+++ b/dlls/atl/atl30.c
@@ -247,7 +247,7 @@ HRESULT WINAPI AtlModuleGetClassObject(_ATL_MODULEW *pm, REFCLSID rclsid,
                                                   (void **)&obj->pCF);
                 if (obj->pCF)
                     hres = IUnknown_QueryInterface(obj->pCF, riid, ppv);
-                break;
+                return hres;
             }
         }
     }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6181

[PATCH 1/1] atl: Only warn in AtlModuleGetClassObject if the class was not found.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=147455

Your paranoid android.


=== debian11 (build log) ===

error: patch failed: dlls/atl/atl30.c:247
Task: Patch failed to apply

=== debian11b (64 bit WoW report) ===

kernel32:
comm.c:1586: Test failed: Unexpected time 1001, expected around 500