[PATCH 0/1] MR1366: winspool.drv: Ignore input in DocumentPropertiesA unless DM_IN_BUFFER is passed.

[Tim Clem (＠tclem)]

The GdiConvertToDevmodeW call can crash if the incoming DEVMODEA has
nonsense values.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1366

[PATCH 1/1] winspool.drv: Ignore input in DocumentPropertiesA unless DM_IN_BUFFER is passed.

[Tim Clem]

From: Tim Clem <tclem(a)codeweavers.com>

The GdiConvertToDevmodeW call can crash if the incoming DEVMODEA has
nonsense values.
---
 dlls/winspool.drv/info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c
index 22422f7e966..c1835695af4 100644
--- a/dlls/winspool.drv/info.c
+++ b/dlls/winspool.drv/info.c
@@ -1895,7 +1895,7 @@ LONG WINAPI DocumentPropertiesA(HWND hwnd, HANDLE printer, char *device_name, DE
         outputW = HeapAlloc(GetProcessHeap(), 0, ret);
     }
 
-    if (input) inputW = GdiConvertToDevmodeW(input);
+    if (input && (mode & DM_IN_BUFFER)) inputW = GdiConvertToDevmodeW(input);
 
     ret = DocumentPropertiesW(hwnd, printer, device, outputW, inputW, mode);
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1366

[PATCH 1/1] winspool.drv: Ignore input in DocumentPropertiesA unless DM_IN_BUFFER is passed.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=126161

Your paranoid android.


=== debian11 (32 bit report) ===

crypt32:
cert.c:4191: Test failed: success
cert.c:4192: Test failed: got 00000000
cert.c:4193: Test failed: got 00000000

[PATCH 0/1] MR1366: winspool.drv: Ignore input in DocumentPropertiesA unless DM_IN_BUFFER is passed. - approved

[Huw Davies (＠huw)]

This merge request was approved by Huw Davies.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1366