[PATCH 0/1] MR3648: server: Set the default thread exit code to 1.

[Brendan Shanks (＠bshanks)]

The default exit code is only used when a process is killed by the system or through a signal.
These are exceptional cases where exit code 1 (killed by Task Manager) is more appropriate than the normal termination code of 0.

Chromium does not restart helper processes that exit with code 0 (see [kill.h](https://source.chromium.org/chromium/chromium/src/+/main:base/process/kill.h...)), with this fix they are restarted when killed by the system or by a signal.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3648

[PATCH 1/1] server: Set the default thread exit code to 1.

[Brendan Shanks]

From: Brendan Shanks <bshanks(a)codeweavers.com>

The default exit code is only used when a process is killed by the
system or through a signal.
These are exceptional cases where exit code 1 (killed by Task Manager)
is more appropriate than the normal termination code of 0.
---
 server/thread.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/thread.c b/server/thread.c
index 3e35b27f694..2621d5af070 100644
--- a/server/thread.c
+++ b/server/thread.c
@@ -239,7 +239,7 @@ static inline void init_thread_structure( struct thread *thread )
     thread->reply_fd        = NULL;
     thread->wait_fd         = NULL;
     thread->state           = RUNNING;
-    thread->exit_code       = 0;
+    thread->exit_code       = 1;  /* default to "killed by Task Manager" unless set otherwise */
     thread->priority        = 0;
     thread->suspend         = 0;
     thread->dbg_hidden      = 0;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3648

[PATCH 1/1] server: Set the default thread exit code to 1.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=136670

Your paranoid android.


=== debian11b (build log) ===

Task: Could not create the wow64 wineprefix: Failed to disable the crash dialogs: 
Task: WineTest did not produce the wow64 report