Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_parser.c:
> IUnknown **object, IUnknown **unknown)
>  {
> -    FIXME("iface %p, index %ld, mt %p, flags %p, lcid %p, group %p, name %p, object %p, unknown %p, stub!\n",
> -            iface, index, mt, flags, lcid, group, name, object, unknown);
> -    return E_NOTIMPL;
> +    struct parser *filter = impl_from_IAMStreamSelect(iface);
> +    wg_parser_stream_t stream = wg_parser_get_stream(filter->wg_parser, index);
> +
> +    FIXME("filter %p, index %ld, mt %p, flags %p, lcid %p, group %p, name %p, object %p, unknown %p, semi-stub!\n",
> +            filter, index, mt, flags, lcid, group, name, object, unknown);
> +
> +    if (!filter->sink.pin.peer)
> +        return VFW_E_NOT_CONNECTED;
> +    if (index < 0 || index >= wg_parser_get_stream_count(filter->wg_parser))
> +        return S_FALSE;
> +

Does the application actually use IAMStreamSelect::Info()? If so we should have tests for it. Also, ideally this'd be a separate patch.

If not I'd just drop this hunk.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_48908