[PATCH 0/1] MR4268: dsuiext: Use CRT allocation functions.

[Alex Henrie (＠alexhenrie)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4268

[PATCH 1/1] dsuiext: Use CRT allocation functions.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 dlls/dsuiext/dsuiext.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/dlls/dsuiext/dsuiext.c b/dlls/dsuiext/dsuiext.c
index 762f7596e73..5867c677f68 100644
--- a/dlls/dsuiext/dsuiext.c
+++ b/dlls/dsuiext/dsuiext.c
@@ -28,7 +28,6 @@
 #include "iads.h"
 #include "dsclient.h"
 
-#include "wine/heap.h"
 #include "wine/debug.h"
 
 WINE_DEFAULT_DEBUG_CHANNEL(dsuiext);
@@ -76,7 +75,7 @@ static ULONG WINAPI dispspec_Release(IDsDisplaySpecifier *iface)
     if (!ref)
     {
         TRACE("destroying %p\n", iface);
-        heap_free(dispspec);
+        free(dispspec);
     }
 
     return ref;
@@ -180,7 +179,7 @@ static HRESULT DsDisplaySpecifier_create(REFIID iid, void **obj)
     DisplaySpec *dispspec;
     HRESULT hr;
 
-    dispspec = heap_alloc(sizeof(*dispspec));
+    dispspec = malloc(sizeof(*dispspec));
     if (!dispspec) return E_OUTOFMEMORY;
 
     dispspec->IDsDisplaySpecifier_iface.lpVtbl = &IDsDisplaySpecifier_vtbl;
@@ -250,7 +249,7 @@ static ULONG WINAPI factory_Release(IClassFactory *iface)
     TRACE("(%p) ref %lu\n", iface, ref);
 
     if (!ref)
-        heap_free(factory);
+        free(factory);
 
     return ref;
 }
@@ -289,7 +288,7 @@ static HRESULT factory_constructor(const struct class_info *info, REFIID riid, v
     class_factory *factory;
     HRESULT hr;
 
-    factory = heap_alloc(sizeof(*factory));
+    factory = malloc(sizeof(*factory));
     if (!factory) return E_OUTOFMEMORY;
 
     factory->IClassFactory_iface.lpVtbl = &factory_vtbl;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4268

[PATCH 1/1] dsuiext: Use CRT allocation functions.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=139510

Your paranoid android.


=== debian11b (64 bit WoW report) ===

ntoskrnl.exe:
driver_pnp.c:731: Test failed: Got 1 remove events.