[PATCH v2 0/1] MR2426: widl: Avoid freeing input_name in pop_import.

[Rémi Bernon]

--
  v2: widl: Avoid freeing input_name in pop_import.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2426

[PATCH v2 1/1] widl: Avoid freeing input_name in pop_import.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

The pointers are used in loc_info input_name without copy.
---
 tools/widl/parser.l | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/widl/parser.l b/tools/widl/parser.l
index 92955516e9e..79f6fee0b5c 100644
--- a/tools/widl/parser.l
+++ b/tools/widl/parser.l
@@ -524,7 +524,7 @@ void pop_import(void)
     if (yyin) fclose( yyin );
     yy_delete_buffer( YY_CURRENT_BUFFER );
     yy_switch_to_buffer( state->buffer );
-    free( input_name );
+
     input_name = state->input_name;
     line_number = state->line_number;
     free( state );
@@ -568,7 +568,6 @@ static void switch_to_acf(void)
 
     if (yyin) fclose( yyin );
     yy_delete_buffer( YY_CURRENT_BUFFER );
-    free( input_name );
 
     input_name = xstrdup( acf_name );
     file = open_input_file( input_name );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2426

[Rémi Bernon]

v2: Don't free the pointers instead of trying to compare values, as it was done before.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2426#note_27162

[Rémi Bernon]

Looks like it fixes the issue now, but there's still some `no space left on device` message when the cache is uploaded.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2426#note_27166