[PATCH 0/1] MR9346: rometadata: Use correct argument when unmapping a file view (Coverity).

[Nikolay Sivov (＠nsivov)]

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9346

[PATCH 1/1] rometadata: Use correct argument when unmapping a file view (Coverity).

[Nikolay Sivov]

From: Nikolay Sivov <nsivov(a)codeweavers.com>

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
---
 dlls/rometadata/assembly.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/rometadata/assembly.c b/dlls/rometadata/assembly.c
index 2703d62fbc7..a76cf6099ec 100644
--- a/dlls/rometadata/assembly.c
+++ b/dlls/rometadata/assembly.c
@@ -835,7 +835,7 @@ void assembly_free(assembly_t *assembly)
     ULONG i;
 
     for (i = 0; i < TABLE_MAX; i++) free(assembly->tables[i].columns_size);
-    if (assembly->map) UnmapViewOfFile(assembly->map);
+    if (assembly->data) UnmapViewOfFile(assembly->data);
     CloseHandle(assembly->map);
     CloseHandle(assembly->file);
     free(assembly);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9346

[Nikolay Sivov (＠nsivov)]

In principle there is no need to keep open mapping and file handles. Once view was mapped those could be safely closed I think.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9346#note_120449