Re: [PATCH v6 0/4] MR5161: d3drm: Implement Update and related functions

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/d3drm/device.c:
> +            RECT rt_rect = { 0, 0, device->width, device->height };
> +            RECT ps_rect = rt_rect;
> +
> +            ClientToScreen(device->window, (POINT *)&ps_rect.left);
> +            ClientToScreen(device->window, (POINT *)&ps_rect.right);
> +
> +            TRACE("primary surface rect %s, render target rect %s\n",
> +                wine_dbgstr_rect(&ps_rect), wine_dbgstr_rect(&rt_rect));
> +
> +            hr = IDirectDrawSurface_Blt(device->primary_surface, &ps_rect,
> +                device->render_target, &rt_rect, DDBLT_WAIT, NULL);
> +        }
> +
> +        device->needs_update = FALSE;
> +    }
> +
> Can there be multiple updates? You mention the possibility of "at least" one update in your tests; should we be storing an array instead?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5161#note_63577