Re: [PATCH v10 0/6] MR6569: winex11: Refactor window state/config tracker to fix race conditions.

1 Dec 2024

      Robbert van der Helm (@robbert-vdh) commented about dlls/winex11.drv/window.c:
...
if (!data->embedded) XIconifyWindow( data->display, data->whole_window, data->vis.screen );
         break;
     }
+
+    /* override redirect windows won't receive WM_STATE property changes */
+    if (!data->managed) data->wm_state_serial = 0;
Hi! 

This specific check causes `ConfigureNotify` events to no longer be processed by top level windows (i.e. managed) windows. as `wm_state_serial` will be set but never cleared again. For the last couple years I've been sending `ConfigureNotify` events to a reparented window to embed Wine windows into other X11 windows, but this specific check breaks that for Wine 9.22. Wine's XEmbed support (which never worked quite as well as the reparent+`ConfigureNotify` approach) also does not seem to work anymore with recent Wine releases.

My question is: is this check necessary to prevent other undesirable interactions and if so, what's the current best way to send X11 window configuration events to Wine windows?

More context: https://github.com/robbert-vdh/yabridge/issues/382#issuecomment-2510155844

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6569#note_89380

Robbert van der Helm (＠robbert-vdh)

tags

participants (1)