Re: [PATCH v5 0/8] MR1088: ntdll: Avoid calling pthread_exit on thread exit.

[Rémi Bernon]

On Tue Oct 18 12:09:32 2022 +0000, **** wrote:
> Marvin replied on the mailing list:
> ```
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The tests also ran into some preexisting test failures. If you know how
> to fix them that would be helpful. See the TestBot job for the details:
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=125085
> Your paranoid android.
> === debian11 (32 bit report) ===
> ddraw:
> ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x1000.
> ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x3000.
> Report validation errors:
> advapi32:security has no test summary line (early exit of the main process?)
> advapi32:security has unaccounted for todo messages
> kernel32:sync has no test summary line (early exit of the main process?)
> === debian11 (build log) ===
> 01d0:err:winediag:d3d_device_create The application wants to create a
> Direct3D device, but the current DirectDrawRenderer does not support this.
> 01d0:err:winediag:d3d_device_create The application wants to create a
> Direct3D device, but the current DirectDrawRenderer does not support this.
> 01d0:err:winediag:d3d_device_create The application wants to create a
> Direct3D device, but the current DirectDrawRenderer does not support this.
> === debian11 (build log) ===
> Use of uninitialized value $Flaky in addition (+) at
> /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24489.
> Use of uninitialized value $Flaky in addition (+) at
> /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24489.
> Use of uninitialized value $Flaky in addition (+) at
> /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24489.
> ```
> I believe these failures should be fixed now, the `kernel32:sync` failure was coming from a thread terminated before it started. This should work fine now.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1088#note_23056