[PATCH v2 0/1] MR5811: user32/tests: Print regions in test_swp_paint_regions failure cases.

[Jinoh Kang (＠iamahuman)]

Follow-up to !3989.

--
  v2: user32/tests: Print regions in test_swp_paint_regions failure cases.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5811

[PATCH v2 1/1] user32/tests: Print regions in test_swp_paint_regions failure cases.

[Jinoh Kang]

From: Jinoh Kang <jinoh.kang.kr(a)gmail.com>

---
 dlls/user32/tests/msg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index 5e69e196e80..60067b7ab02 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -9356,7 +9356,7 @@ static void subtest_swp_paint_regions_( int line, int wrap_toplevel, LPCSTR pare
                 ok( !!rgn_ok, "Parent update region shall match expected region\n" );
             }
 
-            if (!rgn_ok && winetest_debug > 1)
+            if (!rgn_ok)
             {
                 trace( "Expected parent update region: " );
                 dump_region( hrgn_expect );
@@ -9417,7 +9417,7 @@ static void subtest_swp_paint_regions_( int line, int wrap_toplevel, LPCSTR pare
                 ok( !!rgn_ok, "Child update region shall match expected region\n" );
             }
 
-            if (!rgn_ok && winetest_debug > 1)
+            if (!rgn_ok)
             {
                 trace( "Expected child update region: " );
                 dump_region( hrgn_expect_child );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5811

[PATCH v2 1/1] user32/tests: Print regions in test_swp_paint_regions failure cases.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=146202

Your paranoid android.


=== debian11 (32 bit he:IL report) ===

user32:
msg.c:6912: Test failed: SetFocus(hwnd) on a button: 3: the winevent_hook 0x8005 was expected, but got hook 0x0005 instead
msg.c:6912: Test failed: SetFocus(hwnd) on a button: 3: the winevent_hook 0x8005 was expected, but got winevent_hook 0x0003 instead
msg.c:6912: Test failed: SetFocus(hwnd) on a button: 3: the winevent_hook 0x8005 was expected, but got msg 0x030f instead
msg.c:6912: Test failed: SetFocus(hwnd) on a button: 3: the winevent_hook 0x8005 was expected, but got msg 0x001c instead
msg.c:6912: Test failed: SetFocus(hwnd) on a button: 3: the winevent_hook 0x8005 was expected, but got msg 0x0086 instead
msg.c:6912: Test failed: SetFocus(hwnd) on a button: 3: the winevent_hook 0x8005 was expected, but got msg 0x0006 instead
msg.c:6912: Test failed: SetFocus(hwnd) on a button: 3: the winevent_hook 0x8005 was expected, but got hook 0x0009 instead

[PATCH v2 0/1] MR5811: user32/tests: Print regions in test_swp_paint_regions failure cases. - approved

[Alexandre Julliard (＠julliard)]

This merge request was approved by Alexandre Julliard.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5811