[PATCH 0/1] MR2314: user32/tests: Do not stop checking the message list when skipping an optional or unsupported message.
This was either added by accident, or in an attempt to stop checking the message list once we hit a winevent hook todo [and accidentally given too wide of a scope]. However, the same commit also uses a global counter to ensure that only one winevent todo is printed, so we don't need to break here anyway. Fixes: a72bffe768c9fe462010d7e40e20226322fb82c7 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2314
From: Zebediah Figura <zfigura(a)codeweavers.com> This was either added by accident, or in an attempt to stop checking the message list once we hit a winevent hook todo [and accidentally given too wide of a scope]. However, the same commit also uses a global counter to ensure that only one winevent todo is printed, so we don't need to break here anyway. Fixes: a72bffe768c9fe462010d7e40e20226322fb82c7 --- dlls/user32/tests/msg.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 6faaa2c2f40..3c40a9886d2 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -2853,7 +2853,6 @@ static void ok_sequence_(const struct message *expected_list, const char *contex } } expected++; - goto done; } else if (todo) { -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2314
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=130199 Your paranoid android. === w7u_2qxl (32 bit report) === Report validation errors: user32:msg prints too much data (159944 bytes) === w7u_adm (32 bit report) === Report validation errors: user32:msg prints too much data (159861 bytes) === w7u_el (32 bit report) === Report validation errors: user32:msg prints too much data (151479 bytes) === w8 (32 bit report) === Report validation errors: user32:msg prints too much data (144981 bytes) === w8adm (32 bit report) === Report validation errors: user32:msg prints too much data (144981 bytes) === w864 (32 bit report) === Report validation errors: user32:msg prints too much data (144981 bytes) === w1064v1507 (32 bit report) === Report validation errors: user32:msg prints too much data (144912 bytes) === w1064v1809 (32 bit report) === user32: msg.c:7586: Test failed: down to radio3: 10: the msg sequence is not complete: expected 0000 - actual 0084 Report validation errors: user32:msg prints too much data (145414 bytes) === w1064_tsign (32 bit report) === user32: msg.c:7586: Test failed: down to radio3: 10: the msg sequence is not complete: expected 0000 - actual 0084 Report validation errors: user32:msg prints too much data (145941 bytes) === w10pro64 (32 bit report) === Report validation errors: user32:msg prints too much data (144995 bytes) === w11pro64 (32 bit report) === Report validation errors: user32:msg prints too much data (143831 bytes) === w864 (64 bit report) === Report validation errors: user32:msg prints too much data (155413 bytes) === w1064v1507 (64 bit report) === Report validation errors: user32:msg prints too much data (155570 bytes) === w1064v1809 (64 bit report) === user32: msg.c:7586: Test failed: down to radio3: 10: the msg sequence is not complete: expected 0000 - actual 0084 Report validation errors: user32:msg prints too much data (156099 bytes) === w1064_2qxl (64 bit report) === user32: msg.c:7586: Test failed: down to radio3: 10: the msg sequence is not complete: expected 0000 - actual 0084 Report validation errors: user32:msg prints too much data (156088 bytes) === w1064_adm (64 bit report) === user32: msg.c:7586: Test failed: down to radio3: 10: the msg sequence is not complete: expected 0000 - actual 0084 Report validation errors: user32:msg prints too much data (155822 bytes) === w1064_tsign (64 bit report) === user32: msg.c:7586: Test failed: down to radio3: 10: the msg sequence is not complete: expected 0000 - actual 0084 Report validation errors: user32:msg prints too much data (156115 bytes) === w10pro64 (64 bit report) === user32: msg.c:7586: Test failed: down to radio3: 10: the msg sequence is not complete: expected 0000 - actual 0084 Report validation errors: user32:msg prints too much data (155830 bytes) === w10pro64_en_AE_u8 (64 bit report) === Report validation errors: user32:msg prints too much data (146622 bytes) === w10pro64_ar (64 bit report) === Report validation errors: user32:msg prints too much data (146642 bytes) === w10pro64_ja (64 bit report) === Report validation errors: user32:msg prints too much data (146487 bytes) === w10pro64_zh_CN (64 bit report) === Report validation errors: user32:msg prints too much data (146825 bytes) === w11pro64_amd (64 bit report) === Report validation errors: user32:msg prints too much data (154225 bytes) === debian11 (32 bit report) === user32: msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 === debian11 (32 bit ar:MA report) === user32: msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 === debian11 (32 bit de report) === user32: msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 === debian11 (32 bit fr report) === user32: msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 === debian11 (32 bit he:IL report) === user32: msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 === debian11 (32 bit hi:IN report) === user32: msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 === debian11 (32 bit ja:JP report) === user32: msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 === debian11 (32 bit zh:CN report) === user32: msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 === debian11b (32 bit WoW report) === user32: msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014 === debian11b (64 bit WoW report) === user32: msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 4: the msg 0x0047 was expected, but got msg 0x0085 instead msg.c:5796: Test failed: ShowWindow(SW_SHOW):child: 5: the msg sequence is not complete: expected 0000 - actual 0014
participants (3)
-
Marvin -
Zebediah Figura -
Zebediah Figura (＠zfigura)