Re: [PATCH v5 0/4] MR3319: evr: Leave critical section before waiting for streaming thread.
9 Aug
2023
9 Aug
'23
12:57 p.m.
Nikolay Sivov (@nsivov) commented about dlls/evr/presenter.c:
WARN("Failed to get a backbuffer, hr %#lx.\n", hr); }
- EnterCriticalSection(&presenter->cs); + EnterCriticalSection(&presenter->thread.queue.cs); if (presenter->thread.queue.last_presented) IMFSample_Release(presenter->thread.queue.last_presented); presenter->thread.queue.last_presented = sample; IMFSample_AddRef(presenter->thread.queue.last_presented); - LeaveCriticalSection(&presenter->cs); + LeaveCriticalSection(&presenter->thread.queue.cs);
Let's add a local variable for a queue pointer to make this more readable. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3319#note_41780
863
Age (days ago)
863
Last active (days ago)
0 comments
1 participants
participants (1)
-
Nikolay Sivov (@nsivov)