Re: [PATCH v4 0/5] MR3519: windows.devices.enumeration: Implement IDeviceInformationStatics::CreateWatcherAqsFilter().
9 Aug
2023
9 Aug
'23
7:39 a.m.
On Wed Aug 9 04:43:08 2023 +0000, Mohamad Al-Jaf wrote:
I thought I did add `WindowsDeleteString`. I wasn't sure if adding `WindowsDuplicateString` to `device_statics2_CreateWatcher` should be in the same commit or not. I added it in a new commit. Thanks for the review. If you want to put it in a separate commit, it should probably come first, with the field addition and the `WindowsDeleteString` call. Otherwise when `device_statics2_CreateWatcher` was used, `Release` will call `WindowsDeleteString` on destruction with an invalid filter (though perhaps zero-initialized HSTRING is valid, but imho it'd be better that way).
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3519#note_41752
863
Age (days ago)
863
Last active (days ago)
0 comments
1 participants
participants (1)
-
Rémi Bernon