[PATCH 0/1] MR4844: imm32/tests: Add flaky_himc to some ImmTranslateMessage expected calls.
From: Rémi Bernon <rbernon(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=55491 --- dlls/imm32/tests/imm32.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/imm32/tests/imm32.c b/dlls/imm32/tests/imm32.c index 66ebbfd161d..d33bf7ed23e 100644 --- a/dlls/imm32/tests/imm32.c +++ b/dlls/imm32/tests/imm32.c @@ -7081,17 +7081,17 @@ static void test_ImmTranslateMessage( BOOL kbd_char_first ) struct ime_call post_messages[] = { {.hkl = expect_ime, .himc = 0/*himc*/, .func = MSG_TEST_WIN, .message = {.msg = WM_IME_STARTCOMPOSITION, .wparam = 1}}, - {.hkl = expect_ime, .himc = 0/*himc*/, .func = MSG_IME_UI, .message = {.msg = WM_IME_STARTCOMPOSITION, .wparam = 1}}, + {.hkl = expect_ime, .himc = 0/*himc*/, .func = MSG_IME_UI, .message = {.msg = WM_IME_STARTCOMPOSITION, .wparam = 1}, .flaky_himc = TRUE}, {.hkl = expect_ime, .himc = 0/*himc*/, .func = MSG_TEST_WIN, .message = {.msg = WM_IME_ENDCOMPOSITION, .wparam = 1}}, - {.hkl = expect_ime, .himc = 0/*himc*/, .func = MSG_IME_UI, .message = {.msg = WM_IME_ENDCOMPOSITION, .wparam = 1}}, + {.hkl = expect_ime, .himc = 0/*himc*/, .func = MSG_IME_UI, .message = {.msg = WM_IME_ENDCOMPOSITION, .wparam = 1}, .flaky_himc = TRUE}, {0}, }; struct ime_call sent_messages[] = { {.hkl = expect_ime, .himc = 0/*himc*/, .func = MSG_TEST_WIN, .message = {.msg = WM_IME_STARTCOMPOSITION, .wparam = 2}}, - {.hkl = expect_ime, .himc = 0/*himc*/, .func = MSG_IME_UI, .message = {.msg = WM_IME_STARTCOMPOSITION, .wparam = 2}}, + {.hkl = expect_ime, .himc = 0/*himc*/, .func = MSG_IME_UI, .message = {.msg = WM_IME_STARTCOMPOSITION, .wparam = 2}, .flaky_himc = TRUE}, {.hkl = expect_ime, .himc = 0/*himc*/, .func = MSG_TEST_WIN, .message = {.msg = WM_IME_ENDCOMPOSITION, .wparam = 2}}, - {.hkl = expect_ime, .himc = 0/*himc*/, .func = MSG_IME_UI, .message = {.msg = WM_IME_ENDCOMPOSITION, .wparam = 2}}, + {.hkl = expect_ime, .himc = 0/*himc*/, .func = MSG_IME_UI, .message = {.msg = WM_IME_ENDCOMPOSITION, .wparam = 2}, .flaky_himc = TRUE}, {0}, }; HWND hwnd, other_hwnd; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4844
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=141937 Your paranoid android. === w11pro64 (32 bit report) === imm32: imm32.c:1273: Test failed: hwnd is not active imm32.c:1281: Test failed: expected WM_IME_SETCONTEXT_DEACTIVATE imm32.c:1282: Test failed: expected WM_IME_SETCONTEXT_ACTIVATE imm32.c:1290: Test failed: expected WM_IME_SETCONTEXT_DEACTIVATE imm32.c:1291: Test failed: expected WM_IME_SETCONTEXT_ACTIVATE imm32.c:1303: Test failed: expected WM_IME_SETCONTEXT_DEACTIVATE imm32.c:1304: Test failed: expected WM_IME_SETCONTEXT_ACTIVATE imm32.c:1314: Test failed: expected WM_IME_SETCONTEXT_DEACTIVATE imm32.c:1319: Test failed: expected WM_IME_SETCONTEXT_ACTIVATE imm32.c:811: Test failed: unexpected call WM_IME_SETCONTEXT_ACTIVATE imm32.c:1398: Test failed: expected WM_IME_SETCONTEXT_ACTIVATE imm32.c:811: Test failed: unexpected call WM_IME_SETCONTEXT_ACTIVATE
Actually this is failing on Wine and should probably be a conditional todo_wine, will do that instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4844#note_57391
participants (2)
-
Marvin -
Rémi Bernon