[PATCH v2 0/1] MR9955: d2d1: Log errors in d2d_device_context_set_error().
This is helpful to find out d2d errors when they happen. -- v2: d2d1: Warn in d2d_device_context_set_error(). https://gitlab.winehq.org/wine/wine/-/merge_requests/9955
From: Zhiyi Zhang <zzhang@codeweavers.com> This is helpful to find out d2d errors when they happen. --- dlls/d2d1/device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/d2d1/device.c b/dlls/d2d1/device.c index ac1220bc9b3..796bc0938f3 100644 --- a/dlls/d2d1/device.c +++ b/dlls/d2d1/device.c @@ -199,6 +199,7 @@ static void d2d_device_context_draw(struct d2d_device_context *render_target, en static void d2d_device_context_set_error(struct d2d_device_context *context, HRESULT code) { + WARN("code %#lx.\n", code); context->error.code = code; context->error.tag1 = context->drawing_state.tag1; context->error.tag2 = context->drawing_state.tag2; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/9955
On Sat Jan 24 02:29:16 2026 +0000, Nikolay Sivov wrote:
Would a WARN be enough? WARN is also fine. ERR would be more obvious. Anyway, I changed it to WARN.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9955#note_127898
This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9955
participants (3)
-
Nikolay Sivov (@nsivov) -
Zhiyi Zhang -
Zhiyi Zhang (@zhiyi)