Re: [PATCH v2 0/16] MR2386: windows.perception.stub: Implement IHolographicSpaceStatics2/3 interfaces.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about include/windows.graphics.holographic.idl:
> +import "windows.graphics.directx.direct3d11.idl";
> +import "windows.perception.idl";
> +import "windows.perception.spatial.idl";
> +import "windows.ui.core.idl";
> +
> +namespace Windows.Graphics.Holographic {
> +    typedef enum HolographicFramePresentResult HolographicFramePresentResult;
> +    typedef enum HolographicFramePresentWaitBehavior HolographicFramePresentWaitBehavior;
> +    typedef struct HolographicAdapterId HolographicAdapterId;
> +    typedef struct HolographicStereoTransform HolographicStereoTransform;
> +
> +    interface IHolographicCameraPose;
> +    interface IHolographicCameraRenderingParameters;
> +    interface IHolographicFrame;
> +    interface IHolographicFramePrediction;
> +    interface IHolographicSpaceStatics2;
> If you only forward declare `IHolographicSpaceStatics` here, you don't need its definition later in the file, as you also don't implement it.

This then makes 5ec7b6eecc89f2e88df836e1e68c9d59fa640816 ad31506143de193058129e2981818b6e7fc5c252 8fbfa09fd86eb7306688e0914c44964860165a0d 2e1f8bd100e040e8025c5801cecdf7636187582c aaeb3ffc5ce074ddea6a16e5b28788f73b1fd12c also unnecessary, which to be honest, seems appealing to me at least from a review perspective, given the number of new classes and interfaces.

Of course, we might need them later and could be useful to keep them around, but then it would be nice to have it done more gradually if possible.

Regarding 04ee932ff5e261b9aceee47542f91aa6b4f115c1, and for similar changes, it'd be nice to make smaller additions, for instance adding one interface definition at a time (and its dependencies if they aren't too much, or add them beforehand), so that reviewing what needs what is easier.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2386#note_26841