Re: [PATCH v2 0/1] MR1556: d3dcompiler: Implement D3DDisassemble() using vkd3d-shader.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dcompiler_43/compiler.c:
> +        {
> +            const char *ptr = messages;
> +            const char *line;
> +
> +            ERR("Shader log:\n");
> +            while ((line = get_line(&ptr)))
> +            {
> +                ERR("    %.*s", (int)(ptr - line), line);
> +            }
> +            ERR("\n");
> +        }
> +
> +        vkd3d_shader_free_messages(messages);
> +    }
> +
> +    if (ret) return hresult_from_vkd3d_result(ret);
> Tiny nitpick: can you move the return to its own line?
    if (ret)
        return hresult_from_vkd3d_result(ret);

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1556#note_17940